Remove selenium (OpenBB-finance#2898)

* Removed selenium dependency * Removed unused file Co-authored-by: James Maslek <jmaslek11@gmail.com>
newwan · Oct 18, 2022 · 99fc1be · 99fc1be
1 parent 84b0435
commit 99fc1be
Show file tree

Hide file tree

Showing 7 changed files with 2,180 additions and 646 deletions.
diff --git a/custom_pre_commit/check_config_terminal.py b/custom_pre_commit/check_config_terminal.py
diff --git a/jupyterlab/openbb-settings/schema/settings.json b/jupyterlab/openbb-settings/schema/settings.json
@@ -116,24 +116,6 @@
                     "description": "Path to the terminal.py",
                     "default": "terminal.py",
                     "value": ""
-                },
-                "PATH_TO_SELENIUM_DRIVER":
-                {
-                    "type": "string",
-                    "form": "text",
-                    "title": "Path to webdriver",
-                    "description": "Path to the selenium driver",
-                    "default": "",
-                    "value": ""
-                },
-                "WEBDRIVER_TO_USE":
-                {
-                    "type": "string",
-                    "form": "text",
-                    "title": "Webdriver",
-                    "description": "Selenium browser drivers can be found at https://selenium-python.readthedocs.io/installation.html",
-                    "default": "chrome",
-                    "value": ""
                 }
             }
         },

diff --git a/openbb_terminal/economy/finviz_model.py b/openbb_terminal/economy/finviz_model.py
@@ -51,7 +51,6 @@ def get_performance_map(period: str = "1d", map_filter: str = "sp500"):
     # Conversion from period and type, to fit url requirements
     d_period = {"1d": "", "1w": "w1", "1m": "w4", "3m": "w13", "6m": "w26", "1y": "w52"}
     d_type = {"sp500": "sec", "world": "geo", "full": "sec_all", "etf": "etf"}
-    # TODO: Try to get this image and output it instead of opening browser
     url = f"https://finviz.com/map.ashx?t={d_type[map_filter]}&st={d_period[period]}"
     webbrowser.open(url)
     console.print("")