-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modify config #142
base: next
Are you sure you want to change the base?
Modify config #142
Conversation
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #142 +/- ##
===========================================
+ Coverage 35.43% 60.24% +24.81%
===========================================
Files 30 34 +4
Lines 6067 6503 +436
===========================================
+ Hits 2150 3918 +1768
+ Misses 3917 2585 -1332 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# FIXME 66 - could be an AttributeError from self.gisans(). Catch it! | ||
self.gisans(progress=progress) | ||
# -> Is this good enough? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mdoucet do we want any additional handling when this exception is caught? i forgot i tried to handle that in this PR
Description of work:
Renames
~/.refredm.conf
to~/.quicknxs.conf
and removes functionality to read/write nearly all Q settings from this file.as well as adding a button to reset the output filename template to the default.
It also writes
scaling_error
as an additional column to reduced data files, and adds backwards-compatible functionality to read in this new column.Passively adds some type hinting, a util method for reading columns from reduced data, and some other small tweaks/formatting
Check all that apply:
(if not, provide an explanation in the work description)
References:
Manual test for the reviewer
(instructions to set up the environment)
Check list for the reviewer
or an explanation is provided as to why release notes are unnecessary