Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Histogram minimum pin added #162

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Histogram minimum pin added #162

merged 2 commits into from
Feb 10, 2025

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Feb 10, 2025

Short description of the changes:

Histogram minimum pin added to point to the new histogram: 0.4.1rc1
changes based on snapred.

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.26%. Comparing base (8c5e8ed) to head (2836b62).

❌ Your project status has failed because the head coverage (76.26%) is below the target coverage (80.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #162   +/-   ##
=======================================
  Coverage   76.26%   76.26%           
=======================================
  Files          23       23           
  Lines        1403     1403           
=======================================
  Hits         1070     1070           
  Misses        333      333           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@peterfpeterson peterfpeterson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI and recipe look right. You forgot to move the pin in the developer environment.yml to use a package

@mpatrou mpatrou merged commit cef2a6f into next Feb 10, 2025
4 checks passed
@mpatrou mpatrou deleted the histo_min_pin branch February 10, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants