Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue755 module filters #762

Merged
merged 17 commits into from
Jan 13, 2025
Merged

Issue755 module filters #762

merged 17 commits into from
Jan 13, 2025

Conversation

damskii9992
Copy link
Contributor

@damskii9992 damskii9992 commented Jan 8, 2025

This PR adds a dedicated "PlugIns" folder to the application structure with subfolders for BackProjector and Preprocessor modules.
It also adds the defaults to the Linux application, removes old Python versions from CI, adds Python 3.13 and fixes the version of the Ubuntu runner.
The uploaded application folders are also cleaned up and unused code has been removed.

As I am still not used to writing c++ code, please check these parts. I've attempted to copy the code structure.

anderskaestner
anderskaestner previously approved these changes Jan 9, 2025
Copy link
Member

@anderskaestner anderskaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading defaults is broken.
This must be fixed in at least

  • ModuleConfig (modulelibnamemanger,moduleconfig)
  • ReconFramework (ReconConfig, BackProjectorModuleBase, possibly PreprocmoduleBase).

and consequences. Fix under development.

@damskii9992 damskii9992 merged commit 6a97718 into master Jan 13, 2025
24 checks passed
@damskii9992 damskii9992 deleted the issue755_ModuleFilters_2 branch January 13, 2025 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default muhrec parameters not loaded on linux Loading non-module files causes MuhRec to crash
2 participants