feat: allowed ccv,globalfee stargate queries #NTRN-408 #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2024
Merged
pr0n00gler
requested changes
Nov 20, 2024
network/hermes/create-conn.sh
Outdated
|
|
||
|
|
||
| # a short living client is needed for client update proposal test | ||
| echo "Initiating short living client..." |
There was a problem hiding this comment.
Is it possible to move it into the integration tests?
Cause this seems unnecessary in Neutron itself
There was a problem hiding this comment.
We have two sets of configurations for Hermes:
- For use with the cosmospark in integration tests: https://github.com/neutron-org/neutron-integration-tests/blob/main/setup/hermes/create-conn.sh#L13
- For local relay run using the commands 'make init && make start-rly'.
I standardized them, as the command has been present in the hermes (docker) configuration for quite some time.
joldie777
previously approved these changes
Nov 21, 2024
sotnikov-s
reviewed
Nov 25, 2024
network/hermes/create-conn.sh
Outdated
|
|
||
|
|
||
| # a short living client is needed for client update proposal test | ||
| echo "Initiating short living client..." |
NeverHappened
previously approved these changes
Nov 26, 2024
swelf19
dismissed stale reviews from NeverHappened and joldie777
via
66a8aa5
sotnikov-s
approved these changes
Nov 27, 2024
joldie777
approved these changes
Nov 27, 2024
pr0n00gler
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR includes:
Task definition: Add updateParamsPersimmon to chain manager (https://github.com/neutron-org/neutron-dao/tree/main/contracts/dao/neutron-chain-manager) for the following modules:
All prs:
neutron-org/neutronjs#10
neutron-org/neutronjsplus#69
neutron-org/neutron-integration-tests#368
neutron-org/neutron-dao#116
neutron-org/neutron-std#8
#765