-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failures request in contract manager #663
Merged
Merged
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
b7016c1
intro new request & modify old one
quasisamurai 3a7ba9b
upd cli as well
quasisamurai 2bb9d74
rm pagination in single failure resp
quasisamurai b574b37
Merge branch 'main' into fix/failures-fields
quasisamurai 1b22433
Merge branch 'main' into fix/failures-fields
quasisamurai fffb043
Merge branch 'main' into fix/failures-fields
quasisamurai 214a00a
Merge branch 'main' into fix/failures-fields
quasisamurai 6aea5c2
Merge branch 'main' into fix/failures-fields
quasisamurai File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ service Query { | |
} | ||
|
||
// Queries a Failure by contract address and failure ID. | ||
rpc AddressFailure(QueryFailuresRequest) returns (QueryFailuresResponse) { | ||
rpc AddressFailure(QueryFailureRequest) returns (QueryFailuresResponse) { | ||
option (google.api.http).get = "/neutron/contractmanager/failures/{address}/{failure_id}"; | ||
} | ||
|
||
|
@@ -46,6 +46,13 @@ message QueryParamsResponse { | |
|
||
// QueryFailuresRequest is request type for the Query/Failures RPC method. | ||
message QueryFailuresRequest { | ||
// address of the contract which Sudo call failed. | ||
string address = 1; | ||
cosmos.base.query.v1beta1.PageRequest pagination = 3; | ||
} | ||
|
||
// QueryFailureRequest is request type for the Query/Failures RPC method. | ||
message QueryFailureRequest { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
// address of the contract which Sudo call failed. | ||
string address = 1; | ||
// ID of the failure for the given contract. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about making
QueryFailureResponse
struct without pagination? It seems strange that we return it in array even tho it's always one failure. And pagination always null