Skip to content

Commit

Permalink
Merge pull request #331 from neutron-org/chore/clear-globalfee-bypass…
Browse files Browse the repository at this point in the history
…messages

chore: clear globalfee bypassmessages #NTRN-130
  • Loading branch information
pr0n00gler authored Oct 12, 2023

Verified

This commit was signed with the committer’s verified signature.
infosecB Brendan Chamberlain
2 parents 8fff975 + 4612ced commit 785bd59
Showing 2 changed files with 2 additions and 16 deletions.
9 changes: 1 addition & 8 deletions app/upgrades/nextupgrade/upgrades.go
Original file line number Diff line number Diff line change
@@ -17,8 +17,6 @@ import (
upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
"github.com/cosmos/gaia/v11/x/globalfee/types"
v6 "github.com/cosmos/ibc-go/v7/modules/apps/27-interchain-accounts/controller/migrations/v6"
ibcclienttypes "github.com/cosmos/ibc-go/v7/modules/core/02-client/types"
ibcchanneltypes "github.com/cosmos/ibc-go/v7/modules/core/04-channel/types"
ccvconsumertypes "github.com/cosmos/interchain-security/v3/x/ccv/consumer/types"
builderkeeper "github.com/skip-mev/pob/x/builder/keeper"
buildertypes "github.com/skip-mev/pob/x/builder/types"
@@ -260,12 +258,7 @@ func migrateGlobalFees(ctx sdk.Context, keepers *upgrades.UpgradeKeepers) error

ctx.Logger().Info("Global fees was set successfully")

defaultBypassFeeMessages := []string{
sdk.MsgTypeURL(&ibcchanneltypes.MsgRecvPacket{}),
sdk.MsgTypeURL(&ibcchanneltypes.MsgAcknowledgement{}),
sdk.MsgTypeURL(&ibcclienttypes.MsgUpdateClient{}),
}
keepers.GlobalFeeSubspace.Set(ctx, types.ParamStoreKeyBypassMinFeeMsgTypes, &defaultBypassFeeMessages)
keepers.GlobalFeeSubspace.Set(ctx, types.ParamStoreKeyBypassMinFeeMsgTypes, &[]string{})

ctx.Logger().Info("Bypass min fee msg types was set successfully")

9 changes: 1 addition & 8 deletions app/upgrades/nextupgrade/upgrades_test.go
Original file line number Diff line number Diff line change
@@ -20,8 +20,6 @@ import (
upgradetypes "github.com/cosmos/cosmos-sdk/x/upgrade/types"
"github.com/cosmos/gaia/v11/x/globalfee"
globalfeetypes "github.com/cosmos/gaia/v11/x/globalfee/types"
ibcclienttypes "github.com/cosmos/ibc-go/v7/modules/core/02-client/types"
ibcchanneltypes "github.com/cosmos/ibc-go/v7/modules/core/04-channel/types"
"github.com/stretchr/testify/suite"

"github.com/neutron-org/neutron/app/upgrades/nextupgrade"
@@ -98,12 +96,7 @@ func (suite *UpgradeTestSuite) TestGlobalFeesUpgrade() {

var actualBypassFeeMessages []string
globalFeeSubspace.Get(ctx, globalfeetypes.ParamStoreKeyBypassMinFeeMsgTypes, &actualBypassFeeMessages)
requiredBypassMinFeeMsgTypes := []string{
sdk.MsgTypeURL(&ibcchanneltypes.MsgRecvPacket{}),
sdk.MsgTypeURL(&ibcchanneltypes.MsgAcknowledgement{}),
sdk.MsgTypeURL(&ibcclienttypes.MsgUpdateClient{}),
}
suite.Require().Equal(requiredBypassMinFeeMsgTypes, actualBypassFeeMessages)
suite.Require().Equal(0, len(actualBypassFeeMessages))

var actualTotalBypassMinFeeMsgGasUsage uint64
globalFeeSubspace.Get(ctx, globalfeetypes.ParamStoreKeyMaxTotalBypassMinFeeMsgGasUsage, &actualTotalBypassMinFeeMsgGasUsage)

0 comments on commit 785bd59

Please sign in to comment.