Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to test artifacts from GitHub Actions #80

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Add option to test artifacts from GitHub Actions #80

wants to merge 19 commits into from

Conversation

JCGoran
Copy link
Collaborator

@JCGoran JCGoran commented Feb 10, 2025

For details see:
neuronsimulator/nrn#3321

@JCGoran JCGoran marked this pull request as ready for review February 10, 2025 16:40
@JCGoran JCGoran mentioned this pull request Feb 10, 2025
Draft
14 tasks
@JCGoran
Copy link
Collaborator Author

JCGoran commented Feb 12, 2025

It works now: https://github.com/neuronsimulator/nrn-build-ci/actions/runs/13287962084

nrnhines
nrnhines approved these changes Feb 12, 2025
View reviewed changes
Copy link
Member

@nrnhines nrnhines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Though to me the github specifics are all magic :)

@JCGoran
Do not use -L flag when using wget
bfbfad7 
Apparently on Fedora 40 wget was replaced by wget2, which doesn't have
the same flags. Download works fine without it though.
@JCGoran JCGoran changed the title Move from Azure to GHA CI Add option to test artifacts from GitHub Actions Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nrnhines nrnhines nrnhines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JCGoran @nrnhines