Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redirect from wiki node talk local task and link directly to the Discourse episode category #14

Open
Ambient-Impact opened this issue Jan 18, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@Ambient-Impact
Copy link
Member

The current implementation has the following drawbacks:

  1. It's slower than it needs to be because it has to figure out and perform a redirect when you follow the link, instead of when outputting the local task.
  2. It doesn't open in a new tab/window because it doesn't get marked as an external link, since it's technically internal at the time of rendering it.

Reworking the local task to point directly to the relevant Discourse episode category should fix both of the above drawbacks. We should be able to create a deriver plug-in to do this: https://www.drupal.org/docs/drupal-apis/menu-api/providing-module-defined-local-tasks#dynamic-local-task-generation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

1 participant