Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attached data admin view date range filters always match first/last date if selected start/end end is after/before #2

Open
Ambient-Impact opened this issue Jan 19, 2023 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@Ambient-Impact
Copy link
Member

This feels counter-intuitive and at the very least should be exposed on the filter form, and ideally should not match by default in these cases. As a more visual example, take the following:

|-------------------|-------------------|---------------|
^                   ^                   ^               ^
"First date"        2049/10/05          2049/10/09      "Last date"

Currently, choosing "2049/10/05" as the start date to filter will still include every date before it, e.g. "2049/10/04", "2049/10/03", etc., which doesn't make intuitive sense. The same goes for the end date. What is expected from a user's point of view is that choosing an explicit date will exclude all dates outside of that range. For example, choosing "2049/10/05" as a start date should not match "2049/10/04", "2049/10/03", etc.

See neurocracy/drupal-omnipedia-date#2 for implementation details.

@Ambient-Impact Ambient-Impact added bug Something isn't working enhancement New feature or request labels Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant