Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LordMicrostrainIMU's update method differs in signature #307

Open
senthurayyappan opened this issue Nov 20, 2024 · 0 comments
Open

LordMicrostrainIMU's update method differs in signature #307

senthurayyappan opened this issue Nov 20, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@senthurayyappan
Copy link
Member

🐛 Bug Report

LordMicrostrainIMU's update method differs from IMUBase. update method is designed to return None, data_packets can be set as a class attribute that the user can access after update is called.

    def update(self, timeout: int = 500, max_packets: int = 1, return_packets: bool = False) -> Optional[list[Any]]:
        """
        Get IMU data from the Lord Microstrain IMU
        """
        data_packets = self._node.getDataPackets(timeout=timeout, maxPackets=max_packets)
        data_points = data_packets[-1].data()
        self._data = {data.channelName(): data.as_float() for data in data_points}

        if return_packets:
            return data_packets

Problem:

imu.py:110: error: Missing return statement  [return]
imu.py:110: error: Signature of "update" incompatible with supertype "SensorBase"  [override]
imu.py:110: note:      Superclass:
imu.py:110: note:          def update(self) -> None
imu.py:110: note:      Subclass:
imu.py:110: note:          def update(self, timeout: int = ..., max_packets: int = ..., return_packets: bool = ...) -> list[Any] | None
@senthurayyappan senthurayyappan added the bug Something isn't working label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant