[V1] Various updates #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njhill
commented
Nov 6, 2024
Comment on lines
+47
to
+48
| omit_defaults=True, | ||
| gc=False): |
There was a problem hiding this comment.
These also have performance benefit
vllm/v1/engine/async_llm.py
Outdated
Comment on lines
145
to
148
| def _finish_stream(self, request_id: str): | ||
| stream = self.request_streams.pop(request_id) | ||
| if stream is not None: | ||
| stream.finish() |
There was a problem hiding this comment.
We need to remove the stream if it finishes due to a finished request output or due to client cancellation.
vllm/v1/engine/async_llm.py
Outdated
| await self.engine_core.abort_requests_async(request_ids) | ||
| self.detokenizer.abort_requests(request_ids) |
There was a problem hiding this comment.
This shouldn't be needed because the detokenizer removes finished requests itself.
Comment on lines
+324
to
+325
| encoder.encode_into(outputs, buffer) | ||
| socket.send_multipart((buffer, ), |
There was a problem hiding this comment.
This will reuse the buffer rather than allocating one each time.
robertgshaw2-redhat
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments