Skip to content

Commit

Permalink
switch to SIGUSR1
Browse files Browse the repository at this point in the history
  • Loading branch information
robertgshaw2-redhat committed Jan 3, 2025
1 parent 32840f2 commit 884879a
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion vllm/v1/engine/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def signal_handler(signum, frame):
except Exception:
traceback = get_exception_traceback()
logger.error("EngineCore hit an exception: %s", traceback)
parent_process.send_signal(signal.SIGQUIT)
parent_process.send_signal(signal.SIGUSR1)

finally:
if engine_core is not None:
Expand Down
8 changes: 4 additions & 4 deletions vllm/v1/executor/multiproc_executor.py
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ def __init__(self, vllm_config: VllmConfig) -> None:
# and ensure workers will be terminated.
self._finalizer = weakref.finalize(self, self.shutdown)

# The child processes will send SIGQUIT when unrecoverable
# The child processes will send SIGUSR1 when unrecoverable
# errors happen.
def sigusr1_handler(signum, frame):
logger.fatal(
"MulitprocExecutor got SIGQUIT from worker processes, shutting "
"MulitprocExecutor got SIGUSR1 from worker processes, shutting "
"down. See stack trace above for root cause issue.")
# Propagate error up to parent process.
parent_process = psutil.Process().parent()
Expand Down Expand Up @@ -350,10 +350,10 @@ def signal_handler(signum, frame):
logger.debug("Worker interrupted.")

except Exception:
# worker_busy_loop sends exceptons to Executor
# worker_busy_loop sends exceptions exceptons to Executor
# for shutdown, but if there is an error in startup or an
# error with IPC itself, we need to alert the parent.
psutil.Process().parent().send_signal(signal.SIGQUIT)
psutil.Process().parent().send_signal(signal.SIGUSR1)
raise

finally:
Expand Down

0 comments on commit 884879a

Please sign in to comment.