Skip to content

Commit

Permalink
[CI/Build] Add sphinx/rst linter for docs (vllm-project#10366)
Browse files Browse the repository at this point in the history
  • Loading branch information
rafvasq authored Nov 20, 2024
1 parent b4be5a8 commit 709c9f1
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 0 deletions.
32 changes: 32 additions & 0 deletions .github/workflows/sphinx-lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
name: Lint documentation

on:
push:
branches:
- main
paths:
- "docs/**"
pull_request:
branches:
- main
paths:
- "docs/**"

jobs:
sphinx-lint:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.12"]
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@0b93645e9fea7318ecaed2b359559ac225c90a2b # v5.3.0
with:
python-version: ${{ matrix.python-version }}
- name: Install dependencies
run: |
python -m pip install --upgrade pip
pip install -r requirements-lint.txt
- name: Linting docs
run: tools/sphinx-lint.sh
6 changes: 6 additions & 0 deletions format.sh
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ MYPY_VERSION=$(mypy --version | awk '{print $2}')
CODESPELL_VERSION=$(codespell --version)
ISORT_VERSION=$(isort --vn)
CLANGFORMAT_VERSION=$(clang-format --version | awk '{print $3}')
SPHINX_LINT_VERSION=$(sphinx-lint --version | awk '{print $2}')

# # params: tool name, tool version, required version
tool_version_check() {
Expand All @@ -57,6 +58,7 @@ tool_version_check "mypy" "$MYPY_VERSION"
tool_version_check "isort" "$ISORT_VERSION"
tool_version_check "codespell" "$CODESPELL_VERSION"
tool_version_check "clang-format" "$CLANGFORMAT_VERSION"
tool_version_check "sphinx-lint" "$SPHINX_LINT_VERSION"

YAPF_FLAGS=(
'--recursive'
Expand Down Expand Up @@ -313,3 +315,7 @@ if ! git diff --quiet &>/dev/null; then
else
echo "✨🎉 Format check passed! Congratulations! 🎉✨"
fi

echo 'vLLM sphinx-lint:'
tools/sphinx-lint.sh
echo 'vLLM sphinx-lint: Done'
1 change: 1 addition & 0 deletions requirements-lint.txt
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ ruff==0.6.5
codespell==2.3.0
isort==5.13.2
clang-format==18.1.5
sphinx-lint==1.0.0

# type checking
mypy==1.11.1
Expand Down
3 changes: 3 additions & 0 deletions tools/sphinx-lint.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
#!/bin/bash

sphinx-lint --disable trailing-whitespace,missing-final-newline docs

0 comments on commit 709c9f1

Please sign in to comment.