-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[move][logger] Move logger.py
to sparseml.core
#1759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahul-tuli
force-pushed
the
migrate-existing-logger-framework
branch
from
October 11, 2023 18:29
6095216
to
bf22554
Compare
rahul-tuli
changed the title
Move logger.py to sparseml/core
[move][logger] Move Oct 11, 2023
logger.py
to sparseml.core
dsikka
reviewed
Oct 11, 2023
dsikka
previously approved these changes
Oct 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending tests
Looks like there is failing integration test, but otherwise looks fine to me!
|
rahul-tuli
force-pushed
the
migrate-existing-logger-framework
branch
from
October 17, 2023 13:19
cedbd8f
to
5643369
Compare
bfineran
reviewed
Oct 17, 2023
rahul-tuli
force-pushed
the
migrate-existing-logger-framework
branch
from
October 17, 2023 19:47
5643369
to
049a753
Compare
bfineran
approved these changes
Oct 17, 2023
dbogunowicz
approved these changes
Oct 18, 2023
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates existing logger framework to
sparseml.core
Main Changes:
src/sparseml/pytorch/utils/logger.py
-->src/sparseml/core/logger.py
+ update__init__.py
filesAlso asserted that imports work just fine:
Note: Updated import logic to include loggers in
sparseml/pytorch/utils/__init__.py
all above import verified to still work as expected