Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos in README #7

Merged
merged 5 commits into from
Aug 14, 2024
Merged

fix typos in README #7

merged 5 commits into from
Aug 14, 2024

Conversation

andy-neuma
Copy link
Member

@andy-neuma andy-neuma commented Aug 14, 2024 •
edited
Loading

SUMMARY:

  • update README to fix typos

TEST PLAN:
team review

dhuangnm
dhuangnm requested changes Aug 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
dhuangnm
dhuangnm previously approved these changes Aug 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@andy-neuma andy-neuma requested a review from dhuangnm August 14, 2024 14:33
dhuangnm
dhuangnm previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@dhuangnm dhuangnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@andy-neuma andy-neuma changed the title fix typos and remove private URL's fix typos in README Aug 14, 2024
jeanniefinks
jeanniefinks reviewed Aug 14, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
jeanniefinks
jeanniefinks previously approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@jeanniefinks jeanniefinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a minor nit that if you could fix, no need to re-review.

@andy-neuma andy-neuma dismissed stale reviews from jeanniefinks and dhuangnm via 0895aa5 August 14, 2024 22:42
@andy-neuma andy-neuma merged commit dcf11e5 into main Aug 14, 2024
1 check passed
@andy-neuma andy-neuma deleted the readme-updates branch August 14, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhuangnm dhuangnm dhuangnm left review comments

@jeanniefinks jeanniefinks jeanniefinks left review comments

@dbarbuzzi dbarbuzzi Awaiting requested review from dbarbuzzi

@derekk-nm derekk-nm Awaiting requested review from derekk-nm

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andy-neuma @jeanniefinks @dhuangnm