forked from kubernetes-sigs/gateway-api-inference-extension
-
Notifications
You must be signed in to change notification settings - Fork 7
Add load based scorer #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
b76d8a0
Added scorer based on pod's load (length of waiting requests queue)
mayabar 6ef3937
Added scorer based on pod's load (length of waiting requests queue)
mayabar f0f6a0d
Update load based scorer according to scorer API changes
mayabar 8610af0
remove unused import
mayabar fd65a2f
Fixes according to the PR comments
mayabar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
/* | ||
Copyright 2025 The Kubernetes Authors. | ||
|
||
Licensed under the Apache License, Version 2.0 (the "License"); | ||
you may not use this file except in compliance with the License. | ||
You may obtain a copy of the License at | ||
|
||
http://www.apache.org/licenses/LICENSE-2.0 | ||
|
||
Unless required by applicable law or agreed to in writing, software | ||
distributed under the License is distributed on an "AS IS" BASIS, | ||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
See the License for the specific language governing permissions and | ||
limitations under the License. | ||
*/ | ||
package scorers | ||
|
||
import ( | ||
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/config" | ||
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/plugins" | ||
"sigs.k8s.io/gateway-api-inference-extension/pkg/epp/scheduling/types" | ||
) | ||
|
||
type LoadBasedScorer struct{} | ||
|
||
func NewLoadBasedScorer() plugins.Scorer { | ||
return LoadBasedScorer{} | ||
} | ||
|
||
func (s LoadBasedScorer) Name() string { | ||
return "load based scorer" | ||
} | ||
|
||
// Score scores the given pod in range of 0-1 | ||
// Currently metrics contains number of requests waiting in the queue, there is no information about number of requests | ||
// that can be processed in the given pod immediately. | ||
// Pod with empty waiting requests queue is scored with 0.5 | ||
// Pod with requests in the queue will get score between 0.5 and 0. | ||
// Score 0 will get pod with number of requests in the queue equal to the threshold used in load-based filter (QueueingThresholdLoRA) | ||
// In future pods with additional capacity will get score higher than 0.5 | ||
func (s LoadBasedScorer) Score(ctx *types.SchedulingContext, pods []types.Pod) map[types.Pod]float64 { | ||
scoredPods := make(map[types.Pod]float64) | ||
|
||
for _, pod := range pods { | ||
waitingRequests := float64(pod.GetMetrics().WaitingQueueSize) | ||
|
||
if waitingRequests == 0 { | ||
scoredPods[pod] = 0.5 | ||
} else { | ||
scoredPods[pod] = 0.5 * (1.0 - (waitingRequests / float64(config.Conf.QueueingThresholdLoRA))) | ||
} | ||
} | ||
|
||
return scoredPods | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.