-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the logic for perplexity evaluation (Not enough kv_cache capacity to run generation. Please use a larger sequence_length or a shorter prompt
)
#1633
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
021fb13
initial commit
dbogunowicz b12d326
fix tests
dbogunowicz 9216199
Merge branch 'main' into feature/damian/seq_len
dbogunowicz 0596c7d
Merge branch 'main' into feature/damian/seq_len
dbogunowicz 83d8ac6
Merge branch 'main' into feature/damian/seq_len
dbogunowicz ab18e23
Update src/deepsparse/evaluation/utils.py
dbogunowicz 5154d62
quality
dbogunowicz 4d58eb6
initial commit
dbogunowicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,6 +34,7 @@ | |
HumanEvalIteratorWrapper, | ||
process_concatenated_datasets, | ||
) | ||
from deepsparse.transformers.utils.helpers import prepends_bos_token | ||
|
||
|
||
""" | ||
|
@@ -165,6 +166,7 @@ def run_perplexity( | |
return_input_tokens=True, | ||
) | ||
else: | ||
print(len(pipeline.tokenizer(batch[0]).input_ids)) | ||
out = pipeline( | ||
prompt=batch, | ||
output_scores=True, | ||
|
@@ -252,7 +254,15 @@ def load_perplexity_dataset( | |
# fetch max_sequence_length from pipeline if not provided | ||
max_sequence_length = kwargs.pop("max_sequence_length", None) | ||
if max_sequence_length is None and pipeline is not None: | ||
max_sequence_length = pipeline.sequence_length | ||
# max_sequence_length for the dataset concatenation needs to be | ||
# smaller than the kv_cache.capacity | ||
# (pipeline.sequence_length - pipeline.prompt_sequence_length) | ||
max_sequence_length = ( | ||
pipeline.sequence_length - pipeline.prompt_sequence_length - 1 | ||
) | ||
# account for potential additional BOS token | ||
breakpoint() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. debug? |
||
max_sequence_length -= prepends_bos_token(pipeline.tokenizer) | ||
|
||
# fetch model_path from pipeline if not provided | ||
model_path = kwargs.pop("model_path", None) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
debug?