Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TextGeneration] Update doc to be reflective of updated deepsparse defaults #1605

Merged
merged 2 commits into from
Feb 23, 2024
Merged

[TextGeneration] Update doc to be reflective of updated deepsparse defaults #1605

merged 2 commits into from
Feb 23, 2024

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Feb 13, 2024

Summary

  • Update our docs to be reflective of some of the defaults which have been updated for text generation
  • Not a requirement for 1.7 but for completeness, should be up-to-date

New table:
Screenshot 2024-02-13 at 4 00 49 PM

@dsikka dsikka changed the title [TextGeneration] Dpdate doc to be reflective of updated deepsparse defaults [TextGeneration] Update doc to be reflective of updated deepsparse defaults Feb 13, 2024
@dsikka dsikka requested review from mgoin and bfineran February 13, 2024 21:03
mgoin
mgoin approved these changes Feb 14, 2024
View reviewed changes
Copy link
Member

@mgoin mgoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call, thanks!

@mgoin mgoin merged commit 611ec41 into main Feb 23, 2024
13 checks passed
@mgoin mgoin deleted the update_defaults branch February 23, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoin mgoin mgoin approved these changes

@bfineran bfineran Awaiting requested review from bfineran

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dsikka @mgoin