-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
benchmark server pipeline #1600
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
horheynm
requested review from
bfineran and
dsikka
and removed request for
bfineran
February 12, 2024 21:47
…epsparse into benchmark-pipeline-server
dbogunowicz
previously approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we have some tests in?
dsikka
requested changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
- Lets test with an openai example to make sure the integration works
- Add testing, specifically around benchmark_pipeline and server integration
- Refactor benchmark_pipeline function to prevent repeat code
dsikka
reviewed
Feb 26, 2024
horheynm
force-pushed
the
benchmark-pipeline-server
branch
2 times, most recently
from
March 4, 2024 15:31
a1d0237
to
628d4f1
Compare
…epsparse into benchmark-pipeline-server
I addressed tests and refactor, but not testing with openai - talked to Ben, dont need it for now |
dsikka
approved these changes
Mar 6, 2024
dbogunowicz
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
server running pipeline for benchmark
Note: Cannot have continuous batching with timer middleware.
Configs
Server side
client side
Outputs
server
client