-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Branch][DeepSparse Evaluation API] Update lm-eval, perplexity, additional datasets #1580
Merged
Merged
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
6035536
initial implementation
dbogunowicz 53cb9ec
initial commit
dbogunowicz 6599f41
add some more tests for hardening
dbogunowicz 4721c1f
Update src/deepsparse/evaluation/cli.py
dbogunowicz 1247794
Update src/deepsparse/transformers/pipelines/text_generation/pipeline.py
dbogunowicz 9e88f89
Apply suggestions from code review
dbogunowicz fdb21c6
quality
dbogunowicz be80132
Merge branch 'main' into feature/damian/ui_improvements
dbogunowicz 5d40b8d
Merge remote-tracking branch 'origin/main' into feature/damian/fix_lm…
dbogunowicz 3e5b7a8
fix the UI, implement loglikelihood function
dbogunowicz ff0944b
Merge branch 'main' into feature/damian/fix_lm_eval
dbogunowicz f38f0db
remove unneccessary file
dbogunowicz dd45493
Merge branch 'feature/damian/fix_lm_eval' of github.com:neuralmagic/d…
dbogunowicz cd10b92
Merge branch 'main' into feature/damian/ui_improvements
dbogunowicz b2aad17
initial commit
dbogunowicz 35454a1
tests passing, refactor time!
dbogunowicz d3b84f8
cleanup
dbogunowicz e7d8c31
Update test_evaluator.py
dbogunowicz a148fc5
finished
dbogunowicz 3b5977b
rebase
dbogunowicz a9e9847
quality
dbogunowicz 787ee45
rebase
dbogunowicz b5a6d6d
manual testing
dbogunowicz d0698e7
Merge remote-tracking branch 'origin/main' into feature/damian/genera…
dbogunowicz e10f0c9
UI improvements
dbogunowicz 48a5900
new UI adaptations
dbogunowicz 44e3e6e
make test more lightweight
dbogunowicz abb6ab8
fix tests 2
dbogunowicz 79fd7e0
Merge branch 'main' into feature/damian/generate_until
dbogunowicz e5aad65
good point Michael
dbogunowicz 06302dc
Merge branch 'main' into feature/damian/generate_until
dbogunowicz d65cac6
Return to the name `lm-evaluation-harness` but add alias `lm-eval-har…
dbogunowicz e0b4f36
Merge branch 'main' into feature/damian/generate_until
dbogunowicz b82b49b
[DeepSparse Evaluation API] Perplexity (#1555)
dbogunowicz d4cdd98
Merge branch 'main' into feature/damian/generate_until
dbogunowicz 7a3ad2f
move the registration of the perplexity eval function where it belongs
dbogunowicz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when or how will this error during normal use if
raise_error=False
by default? once the eval actually begins?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Good point. Yes, I will change the default behavior of this function, and set raise_error to True.
This is the intended behavior when the acual eval is being ran. At runtime, when the user intends to use
lm-eval
, the module will try to do the hot import of thelm-eval
. If it fails to find the dependency, installed, it will raise the error.However, when testing, I do not want to raise errors, but use the output of this function (boolean) to skip the tests that require lm-eval installed.