Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Text Generation] Fix the. outdated non-kv cache inference pathway #1328

Merged
merged 8 commits into from
Oct 19, 2023

Conversation

dbogunowicz
Copy link
Contributor

As always, our new features slightly broke the non-kv cache inference. This PR updates the pathway.
As a follow-up, my high priority is to finalize the test suite to also include basic testing of the non-kv cache pathway, working on it as we speak.

Copy link

@Satrat Satrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that this is working!

@dbogunowicz dbogunowicz merged commit 3c80189 into main Oct 19, 2023
@dbogunowicz dbogunowicz deleted the feature/damian/adjust_non_kv_cache branch October 19, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants