Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the condition for asymmetric quantization #225

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix the condition for asymmetric quantization #225

wants to merge 2 commits into from

Conversation

dsikka
Copy link
Contributor

@dsikka dsikka commented Dec 11, 2024

Summary

  • Previously, we were not saving the zp if all the values stored in the parameter were 0s
  • However, this fails loading in the event that we're running asymmetric quantization
  • Update the condition to directly check if we're running asym or sym quantization

@dsikka dsikka marked this pull request as draft December 11, 2024 02:36
@dsikka
Copy link
Contributor Author

dsikka commented Dec 11, 2024

Still need to run against all testing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dsikka