-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement aliasable mixin and alias activation ordering #213
Conversation
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
lgtm, |
@horheynm In order to support comparisons natively, at least these two methods must be overloaded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending response to comments!
Signed-off-by: Kyle Sayers <kylesayrs@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM. Seems like our changes to quant args would be backwards compatible but just wanted to confirm that this would be the case?
@dsikka Yes, I am confident that any quantization config produced prior to these changes will be compatible with this new definition. |
This is causing llm-compressor tests to fail: https://github.com/vllm-project/llm-compressor/actions/runs/12090087246/job/33716500170?pr=945 |
The failing tests pass locally with this branch. This points to it being related to different environments, may be a bug present in specific pydantic versions |
I was able to replicate on python3.9 python package environment
Potentially related to https://bugs.python.org/issue43682 |
Purpose
Changes
AliasableEnum
mixin which allows enums to be aliasedAliasableEnum
toActivationOrdering
with the following map:Testing
tests/test_quantization/test_quant_args.py
dynamic
actorder and tested e2e with vllmllama3.py