Add PVC Provisioning Job #916
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AleTopp. Thanks for your PR. I am @kingmakerbot.
Make sure this PR appears in the CrownLabs changelog, adding one of the following labels:
|
|
Managed to have a look. Overall logic now seems fine. Minor changes:
|
|
/deploy-staging |
QcFe
reviewed
Jan 8, 2025
Comment on lines
+60
to
+61
| // ProvisionJobLabel -> Key of the label added by the Provision Job to flag the PVC. | ||
| ProvisionJobLabel = "mydrive-provisioning" |
There was a problem hiding this comment.
please move labels where others are
| @@ -517,6 +532,32 @@ func (r *TenantReconciler) createOrUpdateTnPersonalNFSVolume(ctx context.Context | |||
| return err | |||
| } | |||
| klog.Infof("PVC Secret for tenant %s %s", tn.Name, pvcSecOpRes) | |||
|
|
|||
| val, ok := pvc.Labels[ProvisionJobLabel] | |||
| if !ok || val != ProvisionJobValueOk { | |||
There was a problem hiding this comment.
split the logic based on check. if no labels create, if label is not ok, check if it's done, etc
|
|
||
| klog.Infof("PVC Provisioning Job completed for tenant %s", tn.Name) | ||
| } else if chownJob.Status.Failed == 1 { | ||
| klog.Errorf("PVC Provisioning Job failed for tenant %s", tn.Name) |
There was a problem hiding this comment.
probably better to move into a warning (if exists)
Suggested change
| klog.Errorf("PVC Provisioning Job failed for tenant %s", tn.Name) | |
| klog.Warningf("PVC Provisioning Job failed for tenant %s", tn.Name) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Job that changes the owner of the MyDrive from root (default) to user 1010 (
CrownLabsUserID), so that it is writable by tenants inside Instances deployed as containers (that run as userCrownLabsUserID). If the Job completes, it adds a label to the PVCpvc-provisioning: completedto flag it.Fixes issue: NFS MyDrive cannot be written from containers since owner is root
~ Alessio Giliberti, Chiara Mercurio