[NAE-2051] Implement configurable view in menu items #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement auto-select for menu items
…temoch - fix ActionDelegate.execute method - update ActionDelegate menu item methods - import configuration nets in FilterRunner - implement MenuItemService with new or updated domain models - move menu item domain models to menu package - implement MenuItemView enum - implement MenuItemUtils - rename preference_item to menu_item - add tabbed_case_view_configuration and tabbed_task_view_configuration nets - update MenuItemApiTest according to changes
…temoch - add logging to MenuItemService
…temoch - add or update javadoc
- add translations
- remove redundant MenuItemBody attribute - update menu_item and tabbed_case_view_configuration dataGroups
- update MenuItemService find methods - fix MenuItemApiTest.testDuplicateMenuItem
- update MenuItemBody.setView
Retoocs
added
improvement
Retoocs
requested review from
camperko,
Kovy95,
SamuelPalaj,
MartinSiran and
mazarijuraj
mazarijuraj
requested changes
Feb 17, 2025
| private String menuIcon = "filter_none"; | ||
| private I18nString menuName; | ||
| private Map<String, I18nString> allowedRoles; | ||
| private Map<String, I18nString> bannedRoles; |
There was a problem hiding this comment.
Both role collections are missing initialization in constructors, possible source of NullPointerException.
There was a problem hiding this comment.
I have just added the initialization
- add map initialization in MenuItemBody
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reworked backend solution for menu items. Now you can configure menu item with custom configuration process. New configurations can be added in the future.
Implements NAE-2051
Dependencies
No new dependencies were introduced
Third party dependencies
No new dependencies were introduced
Blocking Pull requests
Depends on #283
How Has Been This Tested?
Manually and by unit tests
Test Configuration
Checklist: