Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add membership and alerting channels #10

Merged
merged 1 commit into from
Mar 15, 2024
Merged

feat: add membership and alerting channels #10

merged 1 commit into from
Mar 15, 2024

Conversation

witalisoft
Copy link
Contributor

features:

  • add membership for spaces and rooms
  • add the most popular notification channels

@witalisoft witalisoft requested a review from a team as a code owner March 13, 2024 13:12
@witalisoft witalisoft requested review from M4itee and a team March 13, 2024 13:12
@M4itee
Copy link

M4itee commented Mar 13, 2024

I will need a demo of it like I already mentioned

vkuznecovas
vkuznecovas reviewed Mar 14, 2024
View reviewed changes
Copy link

@vkuznecovas vkuznecovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done! The code looks good, excellent work on the tests.

While I'm leaving a ton of comments, they are mostly minor & related to consistency in code standard and perhaps simplifying things here and there.

internal/client/notification_discord.go Outdated Show resolved Hide resolved
internal/client/notification_discord.go Outdated Show resolved Hide resolved
internal/client/notification_discord.go Outdated Show resolved Hide resolved
internal/client/notification_discord.go Outdated Show resolved Hide resolved
internal/client/notification_discord.go Outdated Show resolved Hide resolved
internal/provider/room_member_resource.go Outdated Show resolved Hide resolved
internal/provider/room_member_resource.go Outdated Show resolved Hide resolved
internal/provider/room_member_resource.go Outdated Show resolved Hide resolved
internal/provider/space_member_resource.go Outdated Show resolved Hide resolved
internal/provider/space_member_resource.go Outdated Show resolved Hide resolved
@witalisoft witalisoft force-pushed the feat/add-memberships branch from 10a5d9d to 927cc68 Compare March 15, 2024 07:49
@witalisoft witalisoft requested a review from vkuznecovas March 15, 2024 07:52
@witalisoft witalisoft merged commit 0986006 into master Mar 15, 2024
4 checks passed
@witalisoft witalisoft deleted the feat/add-memberships branch March 15, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M4itee M4itee M4itee approved these changes

@vkuznecovas vkuznecovas vkuznecovas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@witalisoft @M4itee @vkuznecovas