Skip to content

Fixes running in netbox-docker with errors on version strings #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

biwhite
Copy link

@biwhite biwhite commented Feb 7, 2025

packaging.version.InvalidVersion: Invalid version: '4.2.3-Docker-3.2.0'

If it's new enough to break due to this reason, it's already on the new module names for import.

Alternative is to check settings.RELEASE.version vs settings.VERSION

`packaging.version.InvalidVersion: Invalid version: '4.2.3-Docker-3.2.0'`

If it's new enough to break due to this reason, it's already on the new module names for import.

Alternative is to check `settings.RELEASE.version` vs `settings.VERSION`
@psuet
Copy link

psuet commented Feb 21, 2025

Tested this. Works! Thanks!

@AravindhStanley
Copy link

Is there any blockers to merge this PR?

@mfiedorowicz
Copy link
Member

Hi @biwhite, apologies for keeping you waiting. Thanks for the fix, all looks good 🙌
We introduced CLA for contributions here, hence to trigger it we need to close and reopen this pull request to trigger CLA assistant workflow. Once it's signed, we should be good to merge it and then release.

@CLAassistant
Copy link

CLAassistant commented Mar 18, 2025

CLA assistant check
All committers have signed the CLA.

@biwhite
Copy link
Author

biwhite commented Mar 20, 2025

Hi, I've removed the unused variables from the try/except blocks. Thanks

@djagoo
Copy link

djagoo commented Apr 7, 2025

Hi, can someone please review this PR, it's a blocker for using the plugin on netbox-docker installations. Thanks.

@BBezaire
Copy link

BBezaire commented Apr 8, 2025

Hi, can someone please review this PR, it's a blocker for using the plugin on netbox-docker installations. Thanks.

I think we're waiting on @biwhite to sign the CLA

@biwhite
Copy link
Author

biwhite commented Apr 8, 2025

Sorry, I'd missed it was waiting on me signing CLA! Now done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants