Skip to content

Commit

Permalink
Refactor DNS label validation in up command to improve error handling
Browse files Browse the repository at this point in the history
  • Loading branch information
hakansa committed Feb 12, 2025
1 parent 94c8f84 commit f041b0f
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions client/cmd/up.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,19 +112,14 @@ func runInForegroundMode(ctx context.Context, cmd *cobra.Command) error {
return err
}

dnsLabelsConverted, err := validateDnsLabels(dnsLabels)
if err != nil {
return err
}

ic := internal.ConfigInput{
ManagementURL: managementURL,
AdminURL: adminURL,
ConfigPath: configPath,
NATExternalIPs: natExternalIPs,
CustomDNSAddress: customDNSAddressConverted,
ExtraIFaceBlackList: extraIFaceBlackList,
DNSLabels: dnsLabelsConverted,
DNSLabels: dnsLabelsValidated,
}

if cmd.Flag(enableRosenpassFlag).Changed {
Expand Down

0 comments on commit f041b0f

Please sign in to comment.