fix: change package and path in protobuf model #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 3, 2024 17:25
pitercl
reviewed
Dec 12, 2024
scripts/generate_proto.sh
Outdated
| SRC_DIR="${SCRIPT_DIR}/../src" | ||
| NEPTUNE_PROJECT_DIR="${1:-}" | ||
|
|
||
| if [ -z "${NEPTUNE_PROJECT_DIR}" ]; then |
There was a problem hiding this comment.
Could we please have an env pointing to ${NEPTUNE_PROJECT_DIR}/libs/models/leaderboard-proto/src/main/proto? I'd prefer to limit how much our repo structure is exposed.
michalsosn
force-pushed
the
ms/patryk-test-3
branch
from
f2d5bd3 to
824fc54
Compare
PatrykGala
approved these changes
Dec 18, 2024
PatrykGala
added a commit
that referenced
this pull request
Dec 18, 2024
This reverts commit 81403e1.
PatrykGala
added a commit
that referenced
this pull request
Dec 18, 2024
PatrykGala
added a commit
that referenced
this pull request
Dec 18, 2024
PatrykGala
added a commit
that referenced
this pull request
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.