Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modelling of Nephio API objects #126

Merged
merged 5 commits into from
May 2, 2024

Conversation

ciaranjohnston
Copy link
Member

After some reviews in the modelling (WG4) meetings somewhat of a consensus has been reached on a view of the Nephio models, and this is the attempt to describe diagrammatically at a hight level what is currently there.

@nephio-prow nephio-prow bot requested review from CsatariGergely and s3wong April 17, 2024 20:29
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for nephio ready!

Name Link
🔨 Latest commit 873e3a0
🔍 Latest deploy log https://app.netlify.com/sites/nephio/deploys/66224de09f749e0009a46d04
😎 Deploy Preview https://deploy-preview-126--nephio.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

content/en/docs/apis/_index.md Show resolved Hide resolved
```


## Porch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this until it is only an empty chapter.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think having a recognition that content is needed here is good. I would work on this over the next few days and make a new PR for that

content/en/docs/apis/_index.md Outdated Show resolved Hide resolved
content/en/docs/apis/_index.md Outdated Show resolved Hide resolved
ciaranjohnston and others added 2 commits April 19, 2024 11:52
Fixed typos in descriptions of modelling

Co-authored-by: Fiachra Corcoran <fiachra.corcoran@est.tech>
…gate to the relevant documentation or source code from the diagram
@CsatariGergely
Copy link
Contributor

/approve

@nephio-prow nephio-prow bot added the approved label Apr 19, 2024
@liamfallon
Copy link
Member

/approve
/lgtm

Copy link
Contributor

nephio-prow bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CsatariGergely, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CsatariGergely,liamfallon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@nephio-prow nephio-prow bot merged commit d2f19f0 into nephio-project:main May 2, 2024
8 checks passed
nephio-prow bot pushed a commit that referenced this pull request Nov 7, 2024
…tion (#178)

Paired with PR [#126](nephio-project/porch#126)

This provides documentation on how to configure porch to use external
private authenticated registries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants