Codebase Refactoring for Consistent Style #572
Conversation
A simple change has been made to correct a minor grammatical mistake in the UserLoginState.razor file within Components/Identity.
# Conflicts: # src/Server.UI/Components/Routes.razor
This commit includes minor formatting changes across several files to improve the readability of the code and adhere to standard coding practices. Changes include code arrangement, the handling of newlines at EOF, and adjusting certain tags for visual consistency.
# Conflicts: # src/Application/Application.csproj # src/Infrastructure/Infrastructure.csproj # src/Server.UI/Server.UI.csproj # src/Server/Server.csproj # tests/Application.IntegrationTests/Application.IntegrationTests.csproj # tests/Application.UnitTests/Application.UnitTests.csproj # tests/Domain.UnitTests/Domain.UnitTests.csproj
…den outer parameter with the same name.
|
@neozhu could you review this PR? |
Happy New Year, Bram1903! I've reviewed the PR you mentioned. Most of the issues I noticed pertain to formatting inconsistencies. I suggest using an .editorconfig file to effectively unify code formatting across different developers. This tool is quite helpful in maintaining consistent coding styles for multiple developers working on the same project across various editors and IDEs. However, if we don't have an .editorconfig file, what other methods would you suggest for standardizing code formatting? |
|
Early happy new year to you as well @neozhu! About the .editorconfig, yes you are correct. We should in fact use an .editorconfig, however the last/current one is really bad. I will be home tomorrow, and create one for this project. I already have something in mind. I'll push the new editorconfig file tomorrow, so we'll just keep this PR open for now! Happy new year, |
|
@neozhu, I updated the |
Description
This pull request addresses the need for a uniform and consistent coding style throughout the project. After a thorough review, it became apparent that the codebase had various inconsistent coding style behaviors, incorrect indenting, and discrepancies in space and white line usage. To enhance readability, maintainability, and collaboration, I have undertaken a comprehensive reformatting of the entire project.
Changes Made
Benefits
Testing
I have tested the refactored code extensively to ensure that the changes do not introduce any functional alterations. All existing functionality should remain intact.
Notes for Reviewers
Please review the changes to ensure that the coding style adjustments align with best practices and project conventions. Feel free to comment if you have any concerns or suggestions, and I will address them as soon as possible.
PS. You may check out the
Code-Reformatbranch to check out the changes I made, so you get a feeling of how much more consistent the entire code base became.Kind regards,
Bram