Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Disable gitignore in globby. #3

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

neogeek
Copy link
Owner

@neogeek neogeek commented Apr 27, 2024

Disabling the .gitignore flag in globbby file pattern match.

Pull Request Type

  • Bugfix
  • Enhancement
  • Documentation
  • Other (please describe):

Relevant Issues

n/a

What was the behavior before this feature/fix?

File patterns in .gitignore were getting ignored from build.

Lowest/fastest time to compile 250 markdown files: 0.300s
Lowest/fastest time to compile 500 markdown files: 0.371s
Lowest/fastest time to compile 1000 markdown files: 0.543s
Lowest/fastest time to compile 2000 markdown files: 0.824s
Lowest/fastest time to compile 4000 markdown files: 1.467s

What is the behavior after this feature/fix?

The .gitignore could be ignoring dynamically created files that the user might want include in the build.

Also, slight improvement to build speed.

Lowest/fastest time to compile 250 markdown files: 0.296s
Lowest/fastest time to compile 500 markdown files: 0.356s
Lowest/fastest time to compile 1000 markdown files: 0.512s
Lowest/fastest time to compile 2000 markdown files: 0.770s
Lowest/fastest time to compile 4000 markdown files: 1.309s

Benchmark Results

Lowest/fastest time to compile 250 markdown files: 0.296s
Lowest/fastest time to compile 500 markdown files: 0.356s
Lowest/fastest time to compile 1000 markdown files: 0.512s
Lowest/fastest time to compile 2000 markdown files: 0.770s
Lowest/fastest time to compile 4000 markdown files: 1.309s

Other Information

@neogeek neogeek added the bug Something isn't working label Apr 27, 2024
@neogeek neogeek merged commit 94484b1 into main Apr 27, 2024
1 check passed
@neogeek neogeek deleted the hotfix/disable-globby-gitignore branch April 27, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant