Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.21.4] ClientHooks#onMouseButtonPost no longer called if Screen handles mouse input. #1945

Open
MrCrayfish opened this issue Feb 7, 2025 · 0 comments
Open

[1.21.4] ClientHooks#onMouseButtonPost no longer called if Screen handles mouse input. #1945

MrCrayfish opened this issue Feb 7, 2025 · 0 comments
Labels
triage Needs triaging and confirmation

Comments

@MrCrayfish
Copy link
Contributor

MrCrayfish commented Feb 7, 2025 •
edited
Loading

Minecraft Version: 1.21.4

NeoForge Version: 21.4.81-beta

Description of issue:
In 1.21.1, when a Screen handles mouse input, it would not prevent ClientHooks#onMouseButtonPost from being called. However in 1.21.4, now with the removal of the Screen.wrapScreenError and simply returning immediately on a successful Screen handle (mouse pressed or released), it no longer reaches the call in question. Dismiss if an intentional change to match vanilla behaviour.
@MrCrayfish MrCrayfish added the triage Needs triaging and confirmation label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Needs triaging and confirmation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MrCrayfish