Disable no-useless-undefined rule in tests

neofinancial · Jan 29, 2021 · e88dc8c · e88dc8c
1 parent 4e33ff4
commit e88dc8c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # Changelog
 
+## 0.6.2 (January 29, 2021)
+
+- Disable `no-useless-undefined` rule in tests
+- Disable `unicorn/prefer-set-has` rule
+- Disable `unicorn/prefer-trim-start-end` rule
+
 ## 0.6.1 (November 22, 2020)
 
 - Disable `no-null` rule in base config

diff --git a/config-base-next.js b/config-base-next.js
@@ -20,11 +20,5 @@ module.exports = {
         'unicorn/no-null': 'warn',
       },
     },
-    {
-      files: ['**/test/**/*'],
-      rules: {
-        'unicorn/no-null': 'off',
-      },
-    },
   ],
 };
diff --git a/config-base.js b/config-base.js
@@ -53,6 +53,7 @@ module.exports = {
         '@typescript-eslint/explicit-module-boundary-types': 'off',
         '@typescript-eslint/no-empty-function': 'off',
         'unicorn/no-null': 'off',
+        'unicorn/no-useless-undefined': 'off',
       },
     },
   ],
@@ -112,7 +113,10 @@ module.exports = {
     'unicorn/no-process-exit': 'off',
     'unicorn/no-reduce': 'warn',
     'unicorn/prefer-optional-catch-binding': 'warn',
+    'unicorn/prefer-set-has': 'off',
     'unicorn/prefer-ternary': 'off',
+    // this rule requires a TypeScript lib target of es2019 or later
+    'unicorn/prefer-trim-start-end': 'off',
     'unicorn/prevent-abbreviations': 'off',
 
     'import/no-restricted-paths': ['error', { zones: [{ target: './src', from: './test' }] }],

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "eslint-config-neo",
-  "version": "0.6.1",
+  "version": "0.6.2",
   "description": "Official Neo Financial ESLint configuration",
   "main": "index.js",
   "author": "Neo Financial Engineering <engineering@neofinancial.com>",