Skip to content

Commit

Permalink
Make ClientCloudArchitectureTest optional
Browse files Browse the repository at this point in the history
As we use Neo4j dev dependencies they are very brittle atm

Co-authored-by: Sören Reichardt <soren.reichardt@neo4j.com>
Co-authored-by: Paul Horn <paul.horn@neo4j.com>
  • Loading branch information
3 people committed Nov 21, 2023
1 parent 207aaf1 commit 38c6e20
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -857,4 +857,9 @@ public DependencyResolver emptyDependencyResolver() {
public String neo4jArrowServerAddressHeader() {
throw new UnsupportedOperationException("Not implemented for Neo4j versions <5.14");
}

@Override
public String metricsManagerClass() {
return "com.neo4j.metrics.global.MetricsManager";
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -509,4 +509,9 @@ public GlobalProcedureRegistry globalProcedureRegistry(org.neo4j.kernel.api.proc
}

public abstract Object cursorContextFactory(Optional<org.neo4j.io.pagecache.tracing.PageCacheTracer> pageCacheTracer);

@Override
public String metricsManagerClass() {
return "com.neo4j.metrics.global.MetricsManager";
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -752,4 +752,9 @@ public boolean isCompositeDatabase(GraphDatabaseService databaseService) {
}

public abstract CursorContextFactory cursorContextFactory(Optional<PageCacheTracer> pageCacheTracer);

@Override
public String metricsManagerClass() {
return "com.neo4j.metrics.global.MetricsManager";
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -317,4 +317,6 @@ TransactionalContext newQueryContext(
DependencyResolver emptyDependencyResolver();

String neo4jArrowServerAddressHeader();

String metricsManagerClass();
}
Original file line number Diff line number Diff line change
Expand Up @@ -480,4 +480,8 @@ public static String neo4jArrowServerAddressHeader() {
private Neo4jProxy() {
throw new UnsupportedOperationException("No instances");
}

public static String metricsManagerClass() {
return IMPL.metricsManagerClass();
}
}

0 comments on commit 38c6e20

Please sign in to comment.