Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a page for each GQLSTATUS error and update the structure #245

Merged
merged 12 commits into from
Feb 4, 2025
Merged

Create a page for each GQLSTATUS error and update the structure #245

merged 12 commits into from
Feb 4, 2025

Conversation

renetapopova
Copy link
Collaborator

@renetapopova renetapopova commented Dec 27, 2024 •
edited
Loading

Need to include also the codes from https://github.com/neo4j/docs-status-codes/pull/249/files

@Lojjs Lojjs self-assigned this Jan 7, 2025
Lojjs
Lojjs requested changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with this massive PR! Most of my comments are small (like copy-paste errors and such), the two bigger ones we can discuss in an upcoming sync

@Lojjs Lojjs mentioned this pull request Jan 13, 2025
Merged
@l-heemann l-heemann mentioned this pull request Jan 17, 2025
Closed
@renetapopova renetapopova force-pushed the dev-split-codes branch 2 times, most recently from 88489e0 to 2664896 Compare January 28, 2025 10:57
@renetapopova renetapopova requested a review from Lojjs February 3, 2025 17:06
@Lojjs Lojjs removed the 2025.01 label Feb 4, 2025
@renetapopova renetapopova requested review from Lojjs and removed request for ggowrimani February 4, 2025 15:59
Lojjs
Lojjs reviewed Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not very clear, meant like this

@renetapopova @Lojjs
Update modules/ROOT/pages/errors/gql-errors/42NA5.adoc
27fc3cf 
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
renetapopova and others added 5 commits February 4, 2025 16:12
@renetapopova @Lojjs
Update modules/ROOT/pages/errors/gql-errors/42NA6.adoc
0724cbc 
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
@renetapopova @Lojjs
Update modules/ROOT/pages/errors/gql-errors/42NA7.adoc
7aafb95 
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
@renetapopova @Lojjs
Update modules/ROOT/pages/errors/gql-errors/index.adoc
6227879 
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
@renetapopova @Lojjs
Update modules/ROOT/pages/errors/gql-errors/index.adoc
35430e8 
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
@renetapopova @Lojjs
Update modules/ROOT/pages/errors/gql-errors/index.adoc
8260ec4 
Co-authored-by: Louise Berglund <louise.berglund@neo4j.com>
@renetapopova renetapopova requested a review from Lojjs February 4, 2025 16:14
@neo-technology-commit-status-publisher
Copy link
Collaborator

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Lojjs
Lojjs approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@Lojjs Lojjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 All good now!

@renetapopova renetapopova merged commit b26018c into neo4j:dev Feb 4, 2025
4 checks passed
@renetapopova renetapopova deleted the dev-split-codes branch February 4, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lojjs Lojjs Lojjs approved these changes

Assignees

@Lojjs Lojjs

Labels
2025.01
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@renetapopova @neo-technology-commit-status-publisher @Lojjs