-
Notifications
You must be signed in to change notification settings - Fork 116
[Protocol] 3 seconds dbft consensus #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Isn't it a policy change, rather than a protocol change? Do we track policy changes in NEPs? |
Maybe
But then this means that any mainnet policy changes (like fees) should be described in NEPs. Which would be nice, but are we ready for it? |
It seems that we're not yet ready. We'd better start with NEPs for protocol changes only, because otherwise we'll end up in a very large amount of pending NEPs describing all Neo policies that need to be created/reviewed/approved. So vote up for not including this change into NEPs. |
|
Is it necessary to add a method to get block time? |
Yes, we have set then we should have get. |
Co-authored-by: Owen <38493437+superboyiii@users.noreply.github.com>
Co-authored-by: Owen <38493437+superboyiii@users.noreply.github.com>
5. Effect on Contracts: | ||
* Contract executions MUST adapt to the new block time for all time-related calculations | ||
* The consensus mechanism MUST read the block time from the Policy contract for each consensus round | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
===Events=== | |
====SetBlockGenTime==== | |
<pre> | |
{ | |
"name": "SetBlockGenTime", | |
"parameters": [ | |
{ | |
"name": "milliseconds", | |
"type": "Integer" | |
} | |
] | |
} | |
</pre> | |
We'd better add an eventlog in the end of the method.
This pr tries to formalize our so called 3-seconds consensus.
It requires hardfork and:
Affected Configurations: