fix: network-scoped alias is supported only for containers in user defined networks

[ChristopherHX]

This Windows only issue is caused by the missing !n.IsHost() in the n.IsUserDefined() function for windows. Act sends the network alias for the host network on windows, linux sees that and calls the same IsUserDefined (but uses the unix definition on the server side), which detects the host network as non user defined network.

On linux and macOS it is impossible to reproduce at the time of creating this change. I don't get why windows has it's own definition, but bad maintained.

The actual code uses IsUserDefined to detect if network aliases are supported, which didn't work on windows due to the mess in the docker client go library.

Thank you docker client.

go\pkg\mod\github.com\docker\docker@v24.0.7+incompatible\api\types\container\hostconfig_unix.go

// IsUserDefined indicates user-created network
func (n NetworkMode) IsUserDefined() bool {
	return !n.IsDefault() && !n.IsBridge() && !n.IsHost() && !n.IsNone() && !n.IsContainer()
}

go\pkg\mod\github.com\docker\docker@v24.0.7+incompatible\api\types\container\hostconfig_windows.go

// IsUserDefined indicates user-created network
func (n NetworkMode) IsUserDefined() bool {
	return !n.IsDefault() && !n.IsNone() && !n.IsBridge() && !n.IsContainer()
}

Why did docker this?

Seems like we have to replace the convenience function with it's unix definition

Important bug fix, I don't have the power

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	1		0	0.02s
✅ REPOSITORY	gitleaks	yes		no	3.08s
✅ REPOSITORY	git_diff	yes		no	0.22s
✅ REPOSITORY	grype	yes		no	11.64s
✅ REPOSITORY	secretlint	yes		no	1.89s
✅ REPOSITORY	trivy-sbom	yes		no	0.86s
✅ REPOSITORY	trufflehog	yes		no	22.77s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[codecov]

Codecov Report

Merging #2075 (a006b92) into master (4989f44) will increase coverage by 0.24%.
Report is 269 commits behind head on master.
The diff coverage is 59.88%.

@@            Coverage Diff             @@
##           master    #2075      +/-   ##
==========================================
+ Coverage   61.22%   61.46%   +0.24%     
==========================================
  Files          46       53       +7     
  Lines        7141     8780    +1639     
==========================================
+ Hits         4372     5397    +1025     
- Misses       2462     2955     +493     
- Partials      307      428     +121     

Files	Coverage Δ
pkg/common/executor.go	51.69% <100.00%> (+1.69%)	⬆️
pkg/container/docker_cli.go	82.23% <ø> (ø)
pkg/container/docker_logger.go	52.08% <ø> (ø)
pkg/runner/step_action_local.go	93.54% <100.00%> (ø)
pkg/runner/step_action_remote.go	91.56% <100.00%> (+0.65%)	⬆️
pkg/runner/step_docker.go	93.18% <100.00%> (ø)
pkg/container/file_collector.go	37.30% <0.00%> (ø)
pkg/container/util.go	0.00% <0.00%> (ø)
pkg/container/docker_build.go	60.00% <80.00%> (+1.02%)	⬆️
...ontainer/linux_container_environment_extensions.go	23.07% <0.00%> (-1.25%)	⬇️
... and 31 more

... and 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

[arashi-dev]

Thanks for your work. I really need it

[0x78f1935]

This would solve Error: failed to start container: Error response from daemon: network-scoped alias is supported only for containers in user defined networks, please approve! Thank you for your contribution!

[Ironeer]

This would solve Error: failed to start container: Error response from daemon: network-scoped alias is supported only for containers in user defined networks, please approve! Thank you for your contribution!

I also ran into the issue that is fixed by this PR. Thank you for fixing it @ChristopherHX

Please review and approve! @ALL

[tyeth]

Thank you for this, I only wish my approval mattered ;)