Job is being skipped regardless "if" condition.

[serious-angel]

Dear Developers,

Thank you very much for the awesome project! ✨

Currently, I am trying to use Gitea v1.21.10 for Action Workflows.

---

Workflow test case

name: 'Deployment Workflow'

on:
  push:
    branches:
      - 'test'
      - 'releases/**'

jobs:

  environment-job:
    name: 'Environment'
    runs-on: 'ubuntu-latest'

    outputs:
      TEST: 'true'

    steps:
      - name: 'Environment Test'
        run: date;

  build-job:
    name: 'Build'
    runs-on: 'ubuntu-latest'
    needs: 'environment-job'
    if: ${{ needs.environment-job.outputs.TEST != 'true' }}

    steps:
      - name: 'Build Test'
        id: 'build-test'
        run: date;

  deploy-job:
    name: 'Deploy'
    runs-on: 'ubuntu-latest'
    needs: 'build-job'

    if: |
      always() &&
      (needs.build-job.result == 'success' || needs.build-job.result == 'skipped')

    steps:
      - name: 'Deploy Test'
        id: 'deploy-test'

        run: date;

---

In the result, the both jobs get skipped:

---

May I ask why does it not run job "Deploy" when job "Build" is marked "skipped"?

Best and kind regards

[ChristopherHX]

• Here in nektos/act needs.build-job.result is empty or undefined for skipped jobs.
  success is set correctly after someone contributed it
  • Feel free to open a bug report
• In gitea/act_runner it's the runner not assigning it properly
  they have created their own single job mechanism that nektos/act doesn't support

Actually my own gitea-actions-runner (a totally different runner for gitea) might be also affected for job if, something I should fix.

[serious-angel]

Thank you very much! Do you know where are the exact source code lines for the first and second cases? I will take a look and hopefully try to contribute when possible!

[ChristopherHX]

Case 1 should be fixed by https://github.com/nektos/act/pull/2276/files

Case 2 fix act_runner to do it like my github-act-runner (est 2021, has a longer livetime than act_runner)
https://github.com/ChristopherHX/github-act-runner/blob/87d16d54778b65a0fe69902a9c9071b96279104d/actionsdotnetactcompat/act_worker.go#L425-L457

[ChristopherHX]

Maybe act_runner is doing it already correctly, https://gitea.com/gitea/act_runner/src/commit/be2df361ef19bbf979f826da999169dc2b0ac298/internal/app/run/workflow.go#L34 however to be honest I don't know.