Tooltip for effective reproductive number #639
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| export interface R0PlotProps { | ||
| R0Trajectory: TimeSeriesWithRange | ||
| width: number | ||
| height: number | ||
| tMin: number | ||
| tMax: number | ||
| labelFormatter: LabelFormatter | ||
| tooltipPosition: Coordinate | undefined |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Consider using '?' syntax to declare this property instead of 'undefined' in its type. (tslint:prefer-optional) @typescript-eslint/tslint/config
Codecov Report
@@ Coverage Diff @@
## master #639 +/- ##
==========================================
- Coverage 22.35% 22.16% -0.19%
==========================================
Files 112 112
Lines 2259 2278 +19
Branches 337 344 +7
==========================================
Hits 505 505
- Misses 1754 1773 +19
|
|
Note, the error bars are not subtracted as of now because I'm anticipating the merge of PR #613 which will change the representation to (20, 50, 80). |
| } | ||
| const formattedLabel = labelFormatter ? labelFormatter(label) : label | ||
| const datum = payload.filter((elt) => typeof elt.dataKey === 'string' && itemsToDisplay.includes(elt.dataKey))[0] | ||
| const round = (value: number): number => Math.round(100 * value) / 100 |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Move arrow function round to the outer scope. unicorn/consistent-function-scoping
| return null | ||
| } | ||
| const formattedLabel = labelFormatter ? labelFormatter(label) : label | ||
| const datum = payload.filter((elt) => typeof elt.dataKey === 'string' && itemsToDisplay.includes(elt.dataKey))[0] |
There was a problem hiding this comment.
[eslint] reported by reviewdog 🐶
Move arrow function round to the outer scope. unicorn/consistent-function-scoping
|
Code Climate has analyzed commit 3d9758f and detected 0 issues on this pull request. View more on Code Climate. |
|
Looks good to me. this should be merged with the |
Related issues and PRs
Issue #581
Description
Gives a tooltip to our plot of the dynamic effective reproductie number
Impacted Areas in the application
DeterministicLinePlot.tsx
LinePlotTooltip.tsx
R0LinePlot.tsx
Testing
Open up the application and see with your eyes.