forked from solidusio/solidus
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] main from solidusio:main #391
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed from Sprockets, since v4. It contains all dependencies that needs to be compiled. Co-Authored-By: Elia Schito <elia@schito.me>
Removing the dependency on sprockets < 4 rack is now unbounded, but rack 3 is only supported from Rails 7.1 up.
[admin] Fix mock components reported location
Add support for Sprockets v4 to the DummyApp
[admin] Require ViewComponent v3.9 with inheritable translations
The coverage shouldn't drop after this change.
…views [admin] Remove previews for non-UI components that didn't add much value
[admin] Consistently use `label` for providing text for table scopes, batch actions and filters
Also removes a repeated configuration.
This format uses the filename:line-number which is easy to copy and paste in most editors.
Make them into a clear list, eventually we'll add specific documentation.
[admin] Order adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )