feat: Improved usability of NEAR CLI in scripts #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artob
reviewed
Feb 4, 2025
FroVolod
force-pushed
the
update-for-quiet-option
branch
from
145b7a9 to
65180f7
Compare
added 7 commits
March 3, 2025 16:29
FroVolod
requested review from
akorchyn,
dj8yfo and
PolyProgrammist
as code owners
added 2 commits
March 5, 2025 12:32
akorchyn
previously approved these changes
Mar 6, 2025
src/commands/account/create_account/fund_myself_create_account/sign_as/mod.rs
Show resolved
Hide resolved
| @@ -138,6 +145,10 @@ fn save_access_key( | |||
| account_id.as_ref(), | |||
| ) | |||
| .wrap_err_with(|| format!("Failed to save a file with access key: {}", public_key_str))?; | |||
| eprintln!("{}", storage_message); | |||
| tracing::info!( | |||
| parent: &tracing::Span::none(), | |||
There was a problem hiding this comment.
why do we need to repeat that parent: none()?
| if let crate::Verbosity::Quiet = verbosity { | ||
| println!("{}", info_str); | ||
| }; | ||
| info_str.push_str("\n------------------------------------"); |
frol
requested changes
Mar 6, 2025
frol
reviewed
Mar 11, 2025
src/common.rs
Outdated
Comment on lines
1340
to
1343
| if let crate::Verbosity::Quiet = verbosity { | ||
| std::io::stdout().write_all(bytes_result)?; | ||
| return Ok(()); | ||
| }; |
There was a problem hiding this comment.
Move this block before let result_output, so the program does not perform useless work.
|
@FroVolod Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 13! @frol received 25 Sloth Points for reviewing and scoring this pull request. Congratulations @FroVolod! Your PR was highly scored and you completed another monthly streak! To keep your monthly streak make another pull request next month and get 8+ score for it What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Merged
akorchyn
pushed a commit
that referenced
this pull request
Mar 13, 2025
## 🤖 New release
* `near-cli-rs`: 0.18.0 -> 0.19.0 (⚠ API breaking changes)
### ⚠ `near-cli-rs` breaking changes
```text
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---
Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/constructible_struct_adds_field.ron
Failed in:
field GlobalContext.verbosity in /tmp/.tmpqoEbVp/near-cli-rs/src/lib.rs:19
--- failure function_missing: pub fn removed or renamed ---
Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/function_missing.ron
Failed in:
function near_cli_rs::common::create_used_account_list_from_keychain, previously in file /tmp/.tmpzjZyQv/near-cli-rs/src/common.rs:2604
--- failure function_parameter_count_changed: pub fn parameter count changed ---
Description:
A publicly-visible function now takes a different number of parameters.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/function_parameter_count_changed.ron
Failed in:
near_cli_rs::common::print_transaction_status now takes 3 parameters instead of 2, in /tmp/.tmpqoEbVp/near-cli-rs/src/common.rs:1323
--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---
Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/struct_pub_field_missing.ron
Failed in:
field teach_me of struct GlobalContext, previously in file /tmp/.tmpzjZyQv/near-cli-rs/src/lib.rs:19
```
<details><summary><i><b>Changelog</b></i></summary><p>
<blockquote>
##
[0.19.0](v0.18.0...v0.19.0)
- 2025-03-12
### Added
- Improved usability of NEAR CLI in scripts
([#445](#445))
- Added "send all" option to fungible tokens
([#440](#440))
- let users specify a memo when sending ft
- A new `--quiet` flag to suppress noisy output in scripting scenarios
([#441](#441))
### Fixed
- Fixed information about successful transfer of "send all" ft tokens
([#447](#447))
- Fixed cli command for memo parameter
([#446](#446))
- Use legacy keychain as a fallback storage when system keychain is not
supported (e.g. WSL, Codespaces, Docker containers, CI)
([#439](#439))
### Other
- [**breaking**] updates near-* dependencies to 0.29 release
([#455](#455))
- Typos fix ([#451](#451))
- Added the ability to add an account ID to the account list without
using the legacy keychain
([#449](#449))
- Updated the copyright year to 2025
([#448](#448))
</blockquote>
</p></details>
---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #437
Running NEAR CLI in the --quiet case:
Running NEAR CLI in the "interactive" case:
