Major update for Signer and Account APIs
#1513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ffddebd The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gagdiez
reviewed
Apr 9, 2025
| networkId: string, | ||
| provider: Provider, | ||
| signer: Signer, | ||
| jsvmAccountId: string |
There was a problem hiding this comment.
we can remove the jsvmAccountId from everywhere, as the jsvm is no longer relevant
gagdiez
reviewed
Apr 9, 2025
| const data = fs.readFileSync(HELLO_WASM_PATH); | ||
| await nearjs.accountCreator.masterAccount.createAndDeployContract(contractId, newPublicKey, data, HELLO_WASM_BALANCE); | ||
| // @ts-expect-error test input | ||
| contract = new Contract(nearjs.accountCreator.masterAccount, contractId, { | ||
| contract = new Contract(nearjs.connection, contractId, { |
There was a problem hiding this comment.
why does contract take a nearjs.connection?
…ys - PublicKey and string
…ead of low-level `query`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight checklist
pnpm changesetto create achangesetJSON document appropriate for this change.Motivation
This PR brings a major update to the near-api-js library, introducing a more streamlined and developer-friendly interface. The core of this update is a new abstraction of Signer, which has been redesigned to focus solely on signing. It no longer requires knowledge of the broader account or network context, allowing for cleaner separation of concerns and easier integration across different environments.
Key Changes
TBD
Example Usage
I’ve opened a companion PR in the
near-api-examplesrepo that demonstrates the new API in actionnear-examples/near-api-examples#6