Fix lockup issues found by @ailisp #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ailisp
reviewed
Jul 5, 2021
Fix comments in lib.rs from https://hackmd.io/@ailisp/rJbiDYr5_
Fix comments in foundation.rs from https://hackmd.io/@ailisp/rJbiDYr5_
Fix comments in foundation_callbacks.rs from https://hackmd.io/@ailisp/rJbiDYr5_
…with getters.rs Fix comments in getters.rs from https://hackmd.io/@ailisp/rJbiDYr5_
Fix comments in internal.rs from https://hackmd.io/@ailisp/rJbiDYr5_
Fix comments in utils.rs from https://hackmd.io/@ailisp/rJbiDYr5_ All these functions were already implemented in near-sdk-rs
Fix comments in types.rs from https://hackmd.io/@ailisp/rJbiDYr5_
Fix comments in owner.rs and owner_callbacks.rs from https://hackmd.io/@ailisp/rJbiDYr5_
telezhnaya
force-pushed
the
olya/fix-lockup-after-review
branch
from
9329c8c to
c996969
Compare
|
Rebased because we merged required PR (nothing is changed in this PR) |
evgenykuzyakov
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit solves #145
The second commit adds the instruction on how to build the contract.
All the other commits are addressing issues in the report file-by-file, you could check them separately if you want to.
I also partially fixed issues from #146, some of them were intersected with the issues from the report.
What haven't been done during this PR:
transfers_information,voting, and other related stuff. While I was rewriting README on the previous iteration, @evgenykuzyakov pointed out that it's not correct to say that transfers were enabled on Oct 13, 2020, because the contract could be invoked not only in the Mainnet, and that date could differ. So, from that point of view, the mechanism should not also be deprecated, it still could be used.foundation_account_idtoterminator_account_idbecause it changes the public interface, so it could break the backward compatibility.@AngelBlock you could be also interested in it