Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with OlympusExtra #28

Open
MagicMicky opened this issue Dec 25, 2023 · 2 comments
Open

Compatibility with OlympusExtra #28

MagicMicky opened this issue Dec 25, 2023 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@MagicMicky
Copy link

MagicMicky commented Dec 25, 2023

Hello!
I've just started playing Hades again, and decided to look into mods.
Having changed monitor since I've played Hades first, I now needed Hepahistos to bring the right resolution to the game. Thanks a lot for building this.

I've also installed OlympusExtra which adds a bunch of boons, dialogues, and... keepsakes.

I've found the keepsake page to be a bit broken after installing both mods. I did not try without and it might be another issue, but this is the result I'm seeing when looking at the keepsake page in my home.

image

I am assuming the addition of the keepsakes (and the added invocation and arrows to switch pages for invocation) are not compatible with the mods.
Might be something to do with the order I installed the mod as well? iirc i installed modimporter, modutility, OlympusExtra and then hephaistos.

Would you be able to help?

Edit: where are my manners, a merry christmas to all of you of course :)

Thanks,
Mickael

@MagicMicky MagicMicky changed the title Comaptibility with OlympusExtra Compatibility with OlympusExtra Dec 25, 2023
@MagicMicky
Copy link
Author

Adding a comment here, looking for issues on the OlympusExtra github page and found this: AlexKage69/OlympusExtra#149 ; thought I would add it here for reference, it's unclear to me how this can be solved

@nbusseneau
Copy link
Owner

Hey, sorry for not answering earlier in here. I actually had started a discussion with Alex directly about this, but we didn't really push for anything. The crux of the issue is that OlympusExtra and Hephaistos both try to hook into the same thing and end up conflicting with each other. From initial investigation, the fix should be done directly in OlympusExtra, because if done in Hephaistos it would require more work and special case handling, whereas in OlympusExtra it could be done in a generic way. However neither Alex nor I got to implementing this.

If anyone wants to take this up, I'm happy to give more pointers. I honestly don't think either of us will ever do it at this point, we've mostly moved on to Hades 2 by now.

@nbusseneau nbusseneau added enhancement New feature or request help wanted Extra attention is needed labels May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants