-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Dont require pybind + test python 3.12 #81
Conversation
... okay for me to update CIs to use Python 3.12 in this PR as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @larsoner, yes this was leftover from another project! Thanks for flagging
absolutely |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #81 +/- ##
==========================================
+ Coverage 81.83% 82.86% +1.02%
==========================================
Files 24 25 +1
Lines 2637 2813 +176
==========================================
+ Hits 2158 2331 +173
- Misses 479 482 +3 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Ready for review/merge from my end. Token can be added whenever you want. It actually seems to be working without it, maybe because this is a personal repo not an org repo? Not sure 🤷 |
Thanks @larsoner |
I think a requirement on
pybind11
might have been errantly added in #68. Perhaps a copy-paste error from adapting another project's pyproject.toml? I don't see it used anywhere but maybe I missed it...Feel free to close if I'm wrong, this is basically a question-as-PR, I am working on a conda-forge recipe and was surprised to see pybind11 in the host reqs.