Replace Alpine.js with JS hooks #818
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pehbehbeh
commented
Feb 5, 2025
# Conflicts: # demo/package.json # guides/upgrading/v0.11.md
pehbehbeh
commented
Feb 5, 2025
krns
reviewed
Feb 6, 2025
krns
reviewed
Feb 6, 2025
krns
reviewed
Feb 6, 2025
Comment on lines
-92
to
-101
| onNodeAdded (node) { | ||
| // Mimic autofocus for dynamically inserted elements | ||
| if (node.nodeType === window.Node.ELEMENT_NODE && node.hasAttribute('autofocus')) { | ||
| node.focus() | ||
|
|
||
| if (node.setSelectionRange && node.value) { | ||
| const lastIndex = node.value.length | ||
| node.setSelectionRange(lastIndex, lastIndex) | ||
| } | ||
| } |
There was a problem hiding this comment.
I can't remember why we added this, but I wanted to add a comment in case this wasn't Alpine's reason (I don't see any Alpine specific code like in onBeforeElUpdated).
There was a problem hiding this comment.
We are not using autofocus in the codebase... so I removed it. Looked like a project-specific thing? But I was wondering about that one, too.
krns
reviewed
Feb 6, 2025
Flo0807
reviewed
Feb 6, 2025
|
Awesome! 🙌 |
|
I noticed a small issue: If you select rows, the action column is not highlighted. |
|
I added |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely removes Alpine.js dependency.
drawercomponent for responsive sidebar.collapsecomponent for sidebar sections and use localstorage via custom events.stickycolumns withIntersectionObserverto dynamically display the column shadow.