Skip to content

Commit

Permalink
Revert "delay virker å blokkere ApplicationStopPreparing-sigalet"
Browse files Browse the repository at this point in the history
This reverts commit 445aac8.

Det virket å fungere likevel, men appene bør konfigurere periodSeconds til 1,
ellers ser det ikke ut til at k8s registrerer at appen ikke er ready.
  • Loading branch information
davidsteinsland committed Nov 23, 2024
1 parent 445aac8 commit 58f2601
Showing 1 changed file with 6 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,13 @@ import io.micrometer.core.instrument.binder.jvm.JvmMemoryMetrics
import io.micrometer.core.instrument.binder.jvm.JvmThreadMetrics
import io.micrometer.core.instrument.binder.system.ProcessorMetrics
import io.micrometer.prometheusmetrics.PrometheusMeterRegistry
import kotlinx.coroutines.CompletableDeferred
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.delay
import kotlinx.coroutines.launch
import kotlinx.coroutines.runBlocking
import org.slf4j.Logger
import org.slf4j.event.Level
import java.net.URI
import java.util.*
import java.util.concurrent.atomic.AtomicBoolean
import kotlin.system.exitProcess
import kotlin.time.Duration
import kotlin.time.Duration.Companion.seconds

Expand Down Expand Up @@ -354,16 +350,12 @@ private data class ShutdownHook(
}

override fun run() {
app.environment.log.info("Shut down hook called.")
runBlocking(Dispatchers.IO) {
app.apply {
environment.log.info("Raising ApplicationStopPreparing.")
monitor.raiseCatching(ApplicationStopPreparing, environment, environment.log)
environment.log.info("waiting $gracefulShutdownDelay before disposing application.")
delay(gracefulShutdownDelay)
environment.log.info("Disposing application")
application.dispose()
}
app.apply {
environment.log.info("Shut down hook called. waiting $gracefulShutdownDelay before disposing application.")
monitor.raiseCatching(ApplicationStopPreparing, environment, environment.log)
runBlocking { delay(gracefulShutdownDelay) }
environment.log.info("Disposing application")
application.dispose()
}
}
}

0 comments on commit 58f2601

Please sign in to comment.