Skip to content

Commit

Permalink
Fiks bug i paginering m. feil compare i findIndex (#2553)
Browse files Browse the repository at this point in the history
Antakeligvis i en refaktorering har det skjedd en glippe og der vi
henter ut verdien for å sammenlikne med manglet det en parantes slik at
funksjonen alltid returnerte `true` og dermed resatte paginering til 0
hver gang useEffecten kjørte.
  • Loading branch information
LudvigHz authored Jan 29, 2025
1 parent cd67578 commit ca01369
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions src/utils/hooks/usePaginering.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,11 @@ function usePaginering<T, K>(
// skifter til riktig side dersom selected-item settes programatisk, og viser riktig side ved mount
if (selectedItem && prevSelectedItem !== selectedItem) {
const compareValue = fieldCompare?.(selectedItem) ?? selectedItem;
const index = list.findIndex((item) => fieldCompare?.(item) ?? item === compareValue);
const index = list.findIndex((item) => (fieldCompare?.(item) ?? item) === compareValue);
const newPage = Math.floor(index / pageSize);
setCurrentPage(newPage);
}
}, [selectedItem, prevSelectedItem, setCurrentPage, pageSize, list, fieldCompare]);
}, [selectedItem, prevSelectedItem, pageSize, list, fieldCompare]);

const prevPage = usePrevious(currentPage);
useEffect(() => {
Expand All @@ -97,10 +97,13 @@ function usePaginering<T, K>(
<Select
value={currentPage}
// @ts-expect-error dårlig typing
//biome-ignore lint/suspicious/noAssignInExpressions: biome migration
selectRef={(ref) => (selectRef.current = ref)} //eslint-disable-line
selectRef={(ref) => {
selectRef.current = ref;
}}
label="Velg paginering"
onChange={(e) => setCurrentPage(Number.parseInt(e.target.value))}
onChange={(e) => {
setCurrentPage(Number.parseInt(e.target.value));
}}
>
{options}
</Select>
Expand Down

0 comments on commit ca01369

Please sign in to comment.